Re: [libvirt] [PATCH] virsh: move command cpu-baseline from domain group to host group.
On 10/15/13 11:44, Daniel P. Berrange wrote:
On Tue, Oct 15, 2013 at 02:02:42PM +0800, liyang wrote:
> cpu-baseline command can compute baseline CPU for a set of given CPUs,
> I think it should not belong to domain group, but now it belongs to
> host group,
> so I moved the related source from virsh-domain.c to virsh-host.c
NACK, it is correct to be against the host - it has many use cases
where there is no domain involved at all.
Well in that case it should probably be in virsh-host.c as the patch is
moving it actually. The commit message isn't clear though.
Daniel
Peter
Attachments:
- signature.asc (application/pgp-signature — 901 bytes)