Re: [libvirt] [PATCH 18/35] qemu: block: Always set discard for storage nodes

On 04/25/2018 11:15 AM, Peter Krempa wrote: > Enabling discard for the storage node allows the format drivers to > discard snapshots and other things, while configuration of the format > layer actually decides whether to actually discard data on request from > the host. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > src/qemu/qemu_block.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Isn't this related to the {disk|src}->discard value? Which we copied from patch 3. So you'd just be unconditionally setting here regardless of what was configured?