Re: [libvirt] [PATCH] lxc: report error message raised by the failing function

Hello Prafull, On Thu, 2018-03-22 at 20:04 +0530, Prafull wrote: > The code that calls VIR_WARN after a function fails, doesn't > report the error message raised by the failing function. > Such error messages are now reported in lxc/lxc_driver.c > > Signed-off-by: Prafullkumar T <talep158(a)gmail.com&gt; Sorry for asking a potentially dumb question, but I know nothing of the Indian culture. Is 'Prafullkumar T' your firstname and lastname? Just make sure your first and last names are used for signing off and committing. For this, set the user.name in your git repo (or globally). You can also change the author of an existing commit with: git commit --amend --author 'fullname <email>' Other than that, your commit looks fine to me. Note that you haven't used your full name as commit author. I'll wait for a v2 with updated names to push.