Re: [libvirt PATCH 10/33] qemu: Introduce qemuDomainDefBootPostParse()
On Thu, Mar 02, 2023 at 04:59:36PM +0100, Michal Prívozník wrote:
On 2/15/23 11:42, Andrea Bolognani wrote:
> +static int
> +qemuDomainDefBootPostParse(virDomainDef *def,
> + virQEMUDriverConfig *cfg)
> +{
> + if (def->os.bootloader || def->os.bootloaderArgs) {
> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> + _("bootloader is not supported by QEMU"));
> + return -1;
> + }
Strictly speaking, this is a validate check. Haven't look into the
future, but feel free to move it there in a follow up patch.
Right. I'll look into it.
In the meantime, I've pushed the series. Thanks a ton for the review!
--
Andrea Bolognani / Red Hat / Virtualization