On 07/12/2012 10:53 AM, Daniel P. Berrange wrote:
On Thu, Jul 12, 2012 at 10:28:17AM -0500, Chuck Short wrote:
Adding CPU encoder/decoder for armhf to avoid runtime error messages.
Signed-off-by: Chuck Short <chuck.short@canonical.com>
Chuck: you used two different email addresses (gmail for authorship, canonical for s-o-b). Which one do you want listed in AUTHORS, or should I even alter the authorship to go by your preferred address? Once your commit is applied, 'make syntax-check' won't pass until we also update AUTHORS to match your preferred listing.
+++ b/src/cpu/cpu_arm.c @@ -0,0 +1,76 @@ +
Opps leading blank line crept in here
ACK.
I've fixed the mentioned nits in my local tree, but don't want to push until I get resolution on the AUTHORS question.
/me wonders if our syntax-check whitespace rule should check for blank lines at the start of file, as well as the end of file.
Should be easy enough; I'll propose that as a separate patch. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org