On Wed, Dec 04, 2013 at 09:52:06AM +0100, Christophe Fergeau wrote:
On Tue, Dec 03, 2013 at 10:21:11AM -0800, Ian Main wrote:
On Thu, Nov 21, 2013 at 09:58:45AM +0100, Christophe Fergeau wrote:
I don't know what the convention is in libvirt-sandbox, but spice-gtk/libvirt-glib try to protect public API calls with g_return_val_if_fail(GVIR_SANDBOX_IS_CONFIG_NETWORK_FILTER(config), NULL); so that invalid objects are caught early on
I notice the whole codebase for libvirt-sandbox doesn't have these checks. Might be worth going through and fixing them at some point. In fact most of the things you mentioned in the review could be applied to most of the code base. I'll see how things go, I may do a clean up patch if others think it's a good idea.
Fine with me, feel free to ignore the coding style related comments which would be better done in a cleanup patch changing the whole code base. On the other hand, these changes can also be done incrementally, starting with the new code you add in your patch ;)
Yeah, I went with the latter.. posted a new patch with cleanups you suggested. Thanks again for the review. Ian