On Wed, Apr 11, 2012 at 06:01:42PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 5:29 PM, Christophe Fergeau <cfergeau@redhat.com> wrote:
What would _USB2 do? Add an _EHCI controller, plus either _PIIX3_UHCI or _PIIX4_UHCI?
From what I remember Hans told me, all the 4 ehci + uhci companions controllers are needed for a proper USB2 setup.
I suggest an enum value such as CONFIG_DOMAIN_SETUP_USB_CONTROLLERS_USB2 for default USB2 setup (using the ICH9 controllers, but could be changed someday perhaps)
When we get into such discussions, I question whether the API is appropriate for libvirt-gconfig. This API should be focusing on the mechanism for creating guest configs & trying to avoid policy based questions, which can be left upto higher level apps/APIs. The concept of 'default usb controllers' seems very policy based to me & different hypervisors will have different views of this. So IMHO we should not add this API Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|