Re: [libvirt] [PATCH 2/2] tests: Don't test user config file if ran as root

On 09/12/2013 01:35 PM, Daniel P. Berrange wrote: > On Thu, Sep 12, 2013 at 01:28:45PM +0200, Martin Kletzander wrote: >> Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; >> --- >> tests/virsh-uriprecedence | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/tests/virsh-uriprecedence b/tests/virsh-uriprecedence >> index f4d84a4..aa90efe 100755 >> --- a/tests/virsh-uriprecedence >> +++ b/tests/virsh-uriprecedence >> @@ -56,7 +56,11 @@ bad_uri="test:///default?bad_uri" >> good_uri="test:///default?good_uri" >> >> printf "uri_default=\"%s\"\n" "$good_uri" >"$XDG_CONFIG_HOME/libvirt/libvirt.conf" >> -test_uri "User config file" >> +if uid_is_privileged_; then >> + test_skip_case "$counter" "User config file" "must be run as root" > > > Should that say 'must not be run as root' ? > ^^^ Yes, should, fixed. > >> +else >> + test_uri "User config file" >> +fi >> >> printf "uri_default=\"%s\"\n" "$bad_uri" >"$XDG_CONFIG_HOME/libvirt/libvirt.conf" >> export LIBVIRT_DEFAULT_URI="$good_uri" > > ACK if you can answer the question either way. > Thanks, should I wait for ACK on 1/2 before pushing or have you seen that in the archives?