Re: [libvirt] [PATCH 1/3] qemu: Allow to specify the sysfs root for qemuBuildCommandLine

On 05/15/2013 07:23 AM, Osier Yang wrote: > On 15/05/13 19:09, Daniel P. Berrange wrote: >> Instead of >> adding many parameters to the API, we could provide a struct > > Agreed, many params is always not good. . > >> containing all the various callbacks needed in one go. >> >> Daniel Maybe each device object could have a "hidden" part (i.e. not necessarily visible in the XML) that can be setup before calling qemuBuildCommandLine(), and qemuBuildCommandline could use that info if it's there, otherwise fills in "null" args on the commandline. I'm not against using a callback when it's appropriate, but I think they hinder proper understanding of code by newcomers, and should be used sparingly unless necessary.