Re: [libvirt] [PATCHv1.5 22/27] qemu: snapshot: Touch up error message

On 11/27/2013 01:14 PM, Michal Privoznik wrote: > On 26.11.2013 17:49, Peter Krempa wrote: >> --- >> src/qemu/qemu_driver.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c >> index d2dbaf5..96bc87e 100644 >> --- a/src/qemu/qemu_driver.c >> +++ b/src/qemu/qemu_driver.c >> @@ -11858,8 +11858,8 @@ qemuDomainSnapshotPrepare(virDomainObjPtr vm, virDomainSnapshotDefPtr def, >> * offline snapshots */ >> if (found_internal && external) { >> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", >> - _("mixing internal and external snapshots is not " >> - "supported yet")); >> + _("mixing internal and external targets for a snapshot " >> + "is not yet supported")); >> goto cleanup; >> } >> > I'm not a native speaker, but I remember being told in school that 'yet' > goes always at the end. So I'll leave this one for somebody else. No, that usage is fine.