Re: [libvirt] [PATCH v2 2/5] conf: add XML schema for domain XML
Thank you for reviewing and sorry for my late response.
>
> Is following better? :-)
>
> Domain process is allowed to...
>
>> + by cap element. What capabilities host supports can be found at
>> + capability XML.
>
> Better to add the virsh command. e.g.
>
> capability XML (virsh capabilities)
Also we need to declare the caps are OS dependant.
I don't know proper "cap" name, so it complied
with that of libcap-ng.
>
>> +</p>
>> +
>> +<pre>
>> + ...
>> +<process>
>> +<cap name="chown"/>
>> +<cap name="dac_override"/>
>> +<cap name="dac_read_search"/>
....
>
> Signed-off-by: Taku Izumi<izumi.taku(a)jp.fujitsu.com>
> Signed-off-by: Shota Hirae<m11g1401(a)hibikino.ne.jp>
> ---
> docs/formatdomain.html.in | 48 ++++++++++++++++++++++++++++++++++++++
> docs/schemas/domaincommon.rng | 52 ++++++++++++++++++++++++++++++++++++++++++
> src/conf/domain_conf.c | 33 ++++++++++++++++++++++++++
> src/conf/domain_conf.h | 2 +
> 4 files changed, 135 insertions(+)
>
And better to add some tests.
What type of test? domain schema test?
--
Best regards,
Taku Izumi <izumi.taku(a)jp.fujitsu.com>