Re: [libvirt] [PATCH v5 1/5] Introduce virDomainFSFreeze() and virDomainFSThaw() public API

On 04/04/2014 02:51 AM, Daniel P. Berrange wrote: > On Thu, Apr 03, 2014 at 11:39:29AM -0400, Tomoki Sekiyama wrote: >> These will freeze and thaw filesystems within guest. The APIs take >>@disks >> and @ndisks parameters to specify disks to be frozen or thawed. >> The parameters can be NULL and 0, then the all mounted filesystes are >> frozen or thawed. If some disks are frozen multiple times, they are not >> thawed until requested to be thawed as many times as freeze request. >> @flags parameter, which are currently not used, is for future >>extensions. >> >> +int virDomainFSThaw(virDomainPtr dom, >> + const char **disks, >> + unsigned int ndisks, >> + unsigned int flags); > > Are all guests OS required to support unfreeze on a per disk > basis. I vaguely recall someone mentioning that some OS can > do all-or-none only. If that's the case, the command can issue an error if disks is non-NULL but the guest agent required an all-or-none operation.