On 03/03/2011 04:54 AM, Daniel P. Berrange wrote:
On Wed, Mar 02, 2011 at 03:07:04PM -0700, Eric Blake wrote:
Outgoing migration still uses a Unix socket and or exec netcat until the next patch.
* src/qemu/qemu_migration.c (qemuMigrationPrepareTunnel): Replace Unix socket with simpler pipe. Suggested by Paolo Bonzini. ---
v1 was ack'd here but not yet applied: https://www.redhat.com/archives/libvir-list/2011-January/msg00742.html changes in v2: rebase to latest upstream
src/qemu/qemu_migration.c | 44 ++++++++++++-------------------------------- 1 files changed, 12 insertions(+), 32 deletions(-)
ACK
Self-NACK - I forgot to FD_CLOEXEC the write side of the pipe (virCommand explicitly closes it anyways, but we might as well be clean on our intentions). I'll fix that in v3. Patch 2/3 is fine as is, but no point in pushing it until there's a client. And patch 3/3 will be heavily reworked in v3 (I'm up to at least 5 separate patches, and counting). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org