Re: [libvirt] [PATCH] test: Add JSON test for query-tpm-types

On 04/25/2013 07:06 AM, Daniel P. Berrange wrote: >On Mon, Apr 22, 2013 at 08:53:24AM -0400, Stefan Berger wrote: >>Add a test case for query-tpm-models QMP command. >> >>Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com&gt; >> >>--- >> tests/qemumonitorjsontest.c | 55 >>++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> >>Index: libvirt/tests/qemumonitorjsontest.c >>=================================================================== >>--- libvirt.orig/tests/qemumonitorjsontest.c >>+++ libvirt/tests/qemumonitorjsontest.c >>@@ -25,6 +25,7 @@ >> #include "qemu/qemu_conf.h" >> #include "virthread.h" >> #include "virerror.h" >>+#include "virstring.h" >> >> >> #define VIR_FROM_THIS VIR_FROM_NONE >>@@ -440,6 +441,59 @@ cleanup: >> >> >> static int >>+testQemuMonitorJSONGetTPMModels(const void *data) >>+{ >>+ virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data; >Don't cast 'void *' I has to be casted due to the const. Adding const before virDomainXMLOptionPtr xmlopt doesn't help it. Also, it's c&p.