Re: [libvirt] [PATCH v2 7/7] vz: relax disk bus controller and device indices check
I think there is a better solution, we should move our checks from
postParse callback to validateCallback.
I'm doing patch series now, so we can discuss these changes a bit later.
On 16.08.2016 15:24, Maxim Nestratov wrote:
We should not be too strict regarding device indices check
because it is not really necessary and in fact it breaks
some common scenarios when CD-ROMs are added as the only deivce
on IDE bus with /dev/hdd device name, which corresponds to
ide0-1-1 device indices, rather than ide0-0-0(hda).
Signed-off-by: Maxim Nestratov <mnestratov(a)virtuozzo.com>
---
src/vz/vz_utils.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/src/vz/vz_utils.c b/src/vz/vz_utils.c
index 312355d..c707309 100644
--- a/src/vz/vz_utils.c
+++ b/src/vz/vz_utils.c
@@ -279,14 +279,6 @@ vzCheckDiskAddressDriveUnsupportedParams(virDomainDiskDefPtr disk)
return -1;
}
- if (busIdx != drive->bus || devIdx != drive->unit) {
- virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
- _("Invalid drive address of disk %s, vz driver "
- "does not support non default name mappings."),
- disk->dst);
- return -1;
- }
-
return 0;
}