Re: [libvirt] [PATCH 1/4] Avoid searching for windres when not building for cygwin or mingw.

According to Diego Elio Pettenò on 2/24/2010 8:04 AM: > Check the host string before deciding whether to look for windres or not. > dnl Look for windres to build a Windows icon resource. > -AC_CHECK_TOOL([WINDRES], [windres], [no]) > -AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != "no"]) > +case "$host" in > + *cygwin* | *mingw* ) > + AC_CHECK_TOOL([WINDRES], [windres], []) > + ;; > +esac > + > +AM_CONDITIONAL([WITH_WIN_ICON], [test "$WINDRES" != ""]) I like the idea. However, shouldn't you also guarantee that WINDRES is set even if $host is not windows-based, so that an inherited $WINDRES in a Linux environment does not cause spurious triggering of the AM_CONDITIONAL?