Re: [libvirt] [PATCH] qemu: Avoid fd leak on incoming tunneled migration
On Sun, Jun 25, 2017 at 09:57:43 -0400, John Ferlan wrote:
On 06/20/2017 12:48 PM, Jiri Denemark wrote:
> While qemuProcessIncomingDefNew takes an fd argument and stores it in
> qemuProcessIncomingDef structure, the caller is still responsible for
> closing the file descriptor.
>
> Introduced by commit v1.2.21-140-ge7c6f4575.
>
> Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
> ---
> src/qemu/qemu_migration.c | 1 -
> src/qemu/qemu_process.c | 3 +++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
Suppose you could have gone the other way too - adding the close in
DefFree... I'm fine with this way though.
I tried. It turned out to be quite ugly because there is a patch in
which we don't want DefFree to close the fd and we'd need to hack around
it there.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
Thanks, pushed.
Jirka