Re: [libvirt-ci PATCH 05/13] config: Introduce a new global config.toml configuration file
On Wed, 2020-04-22 at 15:28 +0200, Erik Skultety wrote:
and it also
has some nice features over the plain INI should we find ourselves in
need of any of such extended features in the future, e.g. table nesting.
Let's hope we never will! :)
diff --git a/config.toml b/config.toml
This is specific to lcitool, so it should go in guests/ rather than
in the top-level directory.
+# Configuration file for the lcitool --
https://gitlab.com/libvirt/libvirt-ci/
+# ============================================================================
s/the //, and I would leave out the URL as well.
+# Initial root password to be set by ansible on the appliance. This
password
+# will only be necessary for serial console access in case something goes
+# horribly wrong, for all other use cases, SSH key authentication will be used
+# instead. (mandatory)
+#root_password = ""
s/ansible/Ansible/
With these nits addressed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization