Re: [PATCH] tools: variables clean-up in libvirt-guests script
>For my project, 'Introducing job control to the storage
driver',
>right now I'm going through the `/src/qemu/THREADS.txt` as well
>as previous work done by Tucker DiNapoli during GSoC'14, as well
>as the proposal of Taowei Luo for GSoC'15. Their email threads
>are surely helping me get a better picture of the project.
>Apart from this, please let me know if there is anything else,
>which could help me with this project. Thansk!
>
Discussing the project would be a good start. You're doing well that you're
reading what was done before, but also make sure to check out what is happening
lately.
I started looking up the changes which happened after that using git-log,
the release notes and also by looking up into the mailing list.
...
>- name=$(guest_name "$uri"
"$guest")
>+ local name=$(guest_name "$uri" "$guest")
It would be nice to have the info about the variable being local in one place,
at the top of the function. Most of us are used to our old C ways here, so
keeping this in a similar fashion could be nice.
I understand that this is not an interesting task and it is also one of the
easiest ones, but the idea for that was created when this actually solved a real
bug. This will probably be a one-off since not much is happening in the script,
but we could have a calmer sleep if the variables are marked properly.
Thanks, Martin for the suggestions. I'll be sending an updated version
of this soon.
Thanks,
Prathamesh Chavan