Re: [libvirt] [PATCH V5 10/10] Add test cases
On 11/17/2011 07:17 PM, Eric Blake wrote:
On 11/17/2011 01:11 PM, Stefan Berger wrote:
> Add test case for the chain names with known prefixes and the chain
> priority.
>
> Signed-off-by: Stefan Berger<stefanb(a)linux.vnet.ibm.com>
>
> ---
> tests/nwfilterxml2xmlin/chain_prefixtest1.xml | 37 +++++++++++++++++++++++++
> tests/nwfilterxml2xmlout/chain_prefixtest1.xml | 21 ++++++++++++++
> tests/nwfilterxml2xmltest.c | 2 +
> 3 files changed, 60 insertions(+)
Yay - more tests is always a good thing.
ACK.
I will add a part 11 with documentation of priorities of the chains. The
'shell variable patch' would then come later, but I will post it.
Thanks again for the review. It really does improve things -- especially
the shell code :-)
Stefan