8 Jan
2014
8 Jan
'14
8:10 p.m.
On Mon, Dec 23, 2013 at 10:55:50PM -0700, Eric Blake wrote: [..snip..]
+ if (virAsprintf(&path, "/proc/%llu/ns/mnt", (unsigned long long)pid) < 0) + goto cleanup; + + if ((fd = open(path, O_RDONLY)) < 0) { + virReportSystemError(errno, "%s", + _("Kernel does not provide mount namespace")); + goto cleanup; + }
So in case mount namespaces are unavailable we'll fail these operations entirely? I think this is the right thing to do but it will break distros that have a too old kernel. So shutting down of containers will no longer work (as it did before). Cheers, -- Guido