Re: [libvirt] [PATCH v3 0/4] vz: add statistics

On 06/26/2015 04:59 PM, Peter Krempa wrote: > On Fri, Jun 26, 2015 at 16:51:59 +0300, Dmitry Guryanov wrote: >> On 06/26/2015 02:24 PM, Nikolay Shirokovskiy wrote: >>> Add vz statistics for network, cpu and memory. >>> >>> CHANGES from v1. >>> subject prefix changed from 'parallels' to 'vz' >>> >>> CHANGES from v2. >>> 1. Concering all patches - most of implementation details are moved to vz_sdk.c. >>> Reason is that first this makes other subsystems statistics to be >>> on par with block device statistics. Second, this way we eliminate >>> small helper functions which arise only because we can't use sdk harness. >>> (like prlsdkGetAdapterIndex in previous versions). Third this way >>> we keep all sdk details in vz_sdk. >>> >>> 2. cleanup patch for net device lookups is added as suggested. >>> >>> 3. memory stats patch stays with macros. First I wanted to >>> use just one big macro with conversion argument but then >>> i hit the VIR_DOMAIN_MEMORY_STAT_UNUSED counter which buries >>> this idea. Finally this variant still seems the best for me. >> ACKed and pushed the whole series. > Broke the build: > > > vz/vz_sdk.c:3681:1: error: no previous prototype for 'prlsdkGetStatsParam' [-Werror=missing-prototypes] > prlsdkGetStatsParam(virDomainObjPtr dom, const char *name, long long *val) > ^ > CC security/libvirt_security_manager_la-security_dac.lo > CC security/libvirt_security_manager_la-security_manager.lo > cc1: all warnings being treated as errors > > Please make sure you run all check before pushing! Sorry, I need to run checks with a new compiler :(