[libvirt] [dbus PATCH v2 08/17] Implement Path property for StorageVol Interface
Signed-off-by: Katerina Koukiou <kkoukiou(a)redhat.com>
Reviewed-by: Ján Tomko <jtomko(a)redhat.com>
---
data/org.libvirt.StorageVol.xml | 5 +++++
src/storagevol.c | 23 +++++++++++++++++++++++
tests/test_storage.py | 1 +
3 files changed, 29 insertions(+)
diff --git a/data/org.libvirt.StorageVol.xml b/data/org.libvirt.StorageVol.xml
index 3b36f3b..03c15c2 100644
--- a/data/org.libvirt.StorageVol.xml
+++ b/data/org.libvirt.StorageVol.xml
@@ -13,5 +13,10 @@
value="See
https://libvirt.org/html/libvirt-libvirt-storage.html#virStorageVolGetKey...
<annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal"
value="const"/>
</property>
+ <property name="Path" type="s" access="read">
+ <annotation name="org.gtk.GDBus.DocString"
+ value="See
https://libvirt.org/html/libvirt-libvirt-storage.html#virStorageVolGetPat...
+ <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal"
value="const"/>
+ </property>
</interface>
</node>
diff --git a/src/storagevol.c b/src/storagevol.c
index b979b82..7f33de8 100644
--- a/src/storagevol.c
+++ b/src/storagevol.c
@@ -68,9 +68,32 @@ virtDBusStorageVolGetKey(const gchar *objectPath,
*value = g_variant_new("s", key);
}
+static void
+virtDBusStorageVolGetPath(const gchar *objectPath,
+ gpointer userData,
+ GVariant **value,
+ GError **error)
+{
+ virtDBusConnect *connect = userData;
+ g_autoptr(virStorageVol) storageVol = NULL;
+ g_autofree gchar *path = NULL;
+
+ storageVol = virtDBusStorageVolGetVirStorageVol(connect, objectPath,
+ error);
+ if (!storageVol)
+ return;
+
+ path = virStorageVolGetPath(storageVol);
+ if (!path)
+ return virtDBusUtilSetLastVirtError(error);
+
+ *value = g_variant_new("s", path);
+}
+
static virtDBusGDBusPropertyTable virtDBusStorageVolPropertyTable[] = {
{ "Name", virtDBusStorageVolGetName, NULL },
{ "Key", virtDBusStorageVolGetKey, NULL },
+ { "Path", virtDBusStorageVolGetPath, NULL },
{ 0 }
};
diff --git a/tests/test_storage.py b/tests/test_storage.py
index 91b2597..d3a8701 100755
--- a/tests/test_storage.py
+++ b/tests/test_storage.py
@@ -140,6 +140,7 @@ class TestStorageVolume(libvirttest.BaseTestClass):
dbus_interface=dbus.PROPERTIES_IFACE)
assert isinstance(props['Key'], dbus.String)
assert isinstance(props['Name'], dbus.String)
+ assert isinstance(props['Path'], dbus.String)
if __name__ == '__main__':
--
2.15.0