Re: [libvirt] [PATCH 3/4] libvirt-guest.init: declare variables as local

On 03/09/2011 02:01 AM, Philipp Hahn wrote:

Declare variables used in function only as local.

Signed-off-by: Philipp Hahn <hahn@univention.de> --- tools/libvirt-guests.init.sh | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/tools/libvirt-guests.init.sh b/tools/libvirt-guests.init.sh index ab2b907..8da7576 100644 --- a/tools/libvirt-guests.init.sh +++ b/tools/libvirt-guests.init.sh @@ -62,6 +62,7 @@ retval() { }

run_virsh() { + local uri

NACK. local is not required by POSIX, therefore it is not portable. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org