Re: [libvirt] [PATCH]lxc: remove redundant mount operation
On 11/08/2013 04:30 PM, Chen Hanxiao wrote:
From: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
If we do not specify a readonly mount, we don't need to
re-mount it again.
Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com>
---
Looks good to me.
ACK
src/lxc/lxc_container.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c
index 255c711..351217a 100644
--- a/src/lxc/lxc_container.c
+++ b/src/lxc/lxc_container.c
@@ -1126,13 +1126,6 @@ static int lxcContainerMountFSBind(virDomainFSDefPtr fs,
_("Failed to make directory %s readonly"),
fs->dst);
}
- } else {
- VIR_DEBUG("Binding %s readwrite", fs->dst);
- if (mount(src, fs->dst, NULL, MS_BIND|MS_REMOUNT, NULL) < 0) {
- virReportSystemError(errno,
- _("Failed to make directory %s readwrite"),
- fs->dst);
- }
}
ret = 0;