Re: [libvirt] [PATCH] conf: Allow disks with identical WWN or serial

On Fri, Jun 24, 2016 at 16:12:58 +0100, Daniel Berrange wrote: > On Fri, Jun 24, 2016 at 05:07:43PM +0200, Peter Krempa wrote: > > Disallowing them broke a use case of testing multipath configurations > > for storage. The original intent was added as it made it impossible to > > use certain /dev/disk-by... links. > > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1349895 > > --- > > src/conf/domain_conf.c | 14 -------------- > > 1 file changed, 14 deletions(-) > > > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > > index 9443281..68e89ed 100644 > > --- a/src/conf/domain_conf.c > > +++ b/src/conf/domain_conf.c [...] > > ACK > > Though perhaps its worth a comment in that function about why we don't > check serial/wwn for future readers. How about: /* Duplicate WWN/serial isn't usually problematic for the OS and * forbiding it would possibly inhibit using multipath configurations */