Re: [libvirt] [PATCH] Check for presence of qemu -nodefconfig option before using it
On 06/24/2010 02:20 PM, Laine Stump wrote:
> And if not, should we add a new file to tests/qemuhelpdata/ that
exposes
> a known qemu version that does support -nodefconfig?
>
I don't think there is currently a publicly available qemu release that
supports -nodefconfig. Should we wait until one exists, or dummy up a
test file?
No need to dummy up a file (otherwise someone will ask us how to get
that version of qemu); we'll just have to remember to add a new file
later on when we officially support a newer released qemu version that
adds -nodefconfig support.
With those answers to my questions, ACK to your patch.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)