Re: [Libvir] bug in xen_unified.c
Hey DV,
On Tue, 2008-01-29 at 05:51 -0500, Daniel Veillard wrote:
On Mon, Jan 28, 2008 at 11:25:12PM +0100, Marcus Meissner wrote:
> Hi,
>
> spotted by gcc 4.3, in libvirt 0.4.0, xen_unified.c:xenUnifiedDomainSuspend()
>
> if (priv->opened[i] &&
> which should probably be:
> if (priv->opened[XEN_UNIFIED_HYPERVISOR_OFFSET] &&
> because it is outside of the loop, and the other indices in that
> if ().
Oops, yup clearly a bug, applied and commited,
I think you forgot to commit this one - I sent the patch again
yesterday before seeing this mail.
Cheers,
Mark.