On Wed, Jan 14, 2009 at 09:34:51AM -0500, Cole Robinson wrote:
Daniel P. Berrange wrote:
On Tue, Jan 13, 2009 at 05:49:02PM +0000, Daniel P. Berrange wrote:
QEMU now has support for a sound card of type "ac97", so enable that in the XML parser / qemu driver.
Also remove some unused cruft relating to sound in Xen.
domain_conf.c | 3 ++- domain_conf.h | 1 + xend_internal.c | 46 ---------------------------------------------- 3 files changed, 3 insertions(+), 47 deletions(-)
Now we added 'ac97', we can no longer blindly convert Xen's 'all' string into all possible sound card types - must restrict it to just the 3 that were around historically. This fixes the Xen test case
Prior to the xml parsing unification, 'pcspk' was not allowed as a valid option for xen. At least the xen version on f8 didn't offer it, so this may be incorrect. Not sure if current upstream xen supports 'pcspk' though.
Yes, logs show I mistakenly added pcspk. I'll remove that from the back-compat support too. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|