Re: [libvirt] [PATCH 1/2] util: Add "shareable" field for virSCSIDevice struct

23 Jan 2014

On 16/01/14 08:51, John Ferlan wrote:
...
On 01/08/2014 09:51 AM, Osier Yang wrote:
<...>
...

diff --git a/src/util/virscsi.c b/src/util/virscsi.c
index 751eaf0..3998c3a 100644
--- a/src/util/virscsi.c
+++ b/src/util/virscsi.c
@@ -58,6 +58,7 @@ struct _virSCSIDevice {
      const char *used_by; /* name of the domain using this dev */
bool readonly;
+    bool shareable;
  };
struct _virSCSIDeviceList {
@@ -185,7 +186,8 @@ virSCSIDeviceNew(const char *adapter,
                   unsigned int bus,
                   unsigned int target,
                   unsigned int unit,
-                 bool readonly)
+                 bool readonly,
+                 bool shareable)
  {
      virSCSIDevicePtr dev, ret = NULL;
      char *sg = NULL;
@@ -201,6 +203,7 @@ virSCSIDeviceNew(const char *adapter,
      dev->target = target;
      dev->unit = unit;
      dev->readonly = readonly;
+    dev->shareable= shareable;
You still didn't add the space here before the "="
ACK if you do. I don't believe this is 1.2.1 material.
This patch is standalone.  Pushed with the indention fixed.

Osier

    