Re: [libvirt] PATCH: Thread-safe error reporting public API
On Fri, Dec 12, 2008 at 04:07:18PM +0000, Daniel P. Berrange wrote:
On Fri, Dec 12, 2008 at 01:31:24PM +0100, Daniel Veillard wrote:
> On Fri, Dec 12, 2008 at 10:51:33AM +0000, Daniel P. Berrange wrote:
> > So I'll make the global virGetLastError() thread-safe, and then
there's
> > no need for the new APIs, and also no need for anyone to call the
> > virConnGetLastError(), though I'll make sure that still syncs to
> > whatever error is stored in the global location anyway.
>
> okay, cool !
Try out this patch. The virConn*Error methods are left as is, and the
global vir*Error methods are made to use a thread local
Resurecting that old thread, I think this is still needed for 0.6.0
patch sounds fine to me, what about pushing it ?
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/