Re: [libvirt PATCH v2] port libvirt to Meson build system
On Thu, Jul 30, 2020 at 01:19:54PM +0200, Peter Krempa wrote:
On Wed, Jul 29, 2020 at 16:38:20 +0200, Pavel Hrdina wrote:
> The second time around I will not post the complete series as it doesn't
> make that much sense. Instead I'll post a diff between the two series to
> provide the changes between these series together with links to both
> versions pushed to gitlab repository.
Looks like that everything I've required is dealt with.
Since the version in the repository now correctly generates kbase files
which I've reported offline yesterday and I don't see any problem
myself:
Series
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
Thanks a lot for the review, I take that the series is now somehow ready
to be pushed. Since I'll be pushing it right after the release is done
there is still some time for others to take a look and check that
everything is OK.
With the fix for generated kbase files the gitlab ci discovered a
race-condition with come generated header files. libvirt_driver.a static
library includes "rpc/virnetprotocol.h" in libvirt-stream.c but that
header file is generated during build time so we need to add a 'rpc_dep'
dependency to make sure that the header file is generated before
building this library.
There was a similar issue with virt_daemons where we indirectly include
"admin/admin_protocol.h" which is also generated at build time so we
need to add 'admin_dep'.
I've already pushed that fix into gitlab and the CI works correctly now.
Looking forward to finally have this huge task done \o/.
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)