Re: [libvirt] [PATCH] Remove redundant usage of WITH_YAJL
On 12/12/19 6:22 PM, Ján Tomko wrote:
As of commit 2a00ef6e71f30241f9ca6288da984d75f3cef957 which
was released in v5.2.0, we require YAJL to build the QEMU driver.
Remove the checks from code that requires the QEMU driver
or checks that also check for WITH_QEMU.
Signed-off-by: Ján Tomko <jtomko(a)redhat.com>
---
src/qemu/qemu_driver.c | 5 -----
tests/cputest.c | 16 +++++++-------
tests/qemuagenttest.c | 5 -----
tests/qemublocktest.c | 42 ++++++++++++++-----------------------
tests/qemumigparamstest.c | 5 -----
tests/qemumonitorjsontest.c | 5 -----
6 files changed, 24 insertions(+), 54 deletions(-)
You can also skip checks from:
tests/qemucapabilitiestest.c
tests/qemucaps2xmltest.c
tests/qemucommandutiltest.c
tests/qemuhotplugtest.c
since these are ale guarded by WITH_QEMU check which can be true only if
WITH_YAJL is true. With that:
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal