Re: [PATCH] storage: zfs: split pool and volume names properly

On 6/1/22 23:54, Fabian Lesniak wrote:

Before, the volume name was determined as the last token after any / character. This does not work with zvols below the top level of the pool: /dev/zvols/pool/images/vm1 is truncated to /dev/zvols/pool/vm1. This patch removes the pool name only, so when using the pool "pool", the volume path "images/vm1" is used. --- src/storage/storage_backend_zfs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)

Hey, the patch looks okay and I'd merge it. But it's missing your Signed-off-by line. It's a requirement per: https://libvirt.org/hacking.html#developer-certificate-of-origin It's okay when you reply to this e-mail with your SoB line, I'll amend it. Michal