Re: [libvirt] [PATCH] hyperv: Avoid Coverity warning about resource leak in hypervOpen
2013/1/10 Eric Blake <eblake(a)redhat.com>:
On 01/10/2013 02:48 PM, Matthias Bolte wrote:
> Coverity tagged the esxhypervPrivate pointer a potentially leaked
You already fixed this typo..
> because of the conditional free call. But this is a false positive,
> there is not actual leak.
>
> Avoid the conditial code to make this more obvious to Coverity.
but be sure you also s/conditial/conditional/
> ---
>
> This patch is meant as a replacement for this patch
>
> https://www.redhat.com/archives/libvir-list/2013-January/msg00542.html
ACK.
As it turned out, the cause for the Coverity warning was in VIR_FREE.
But I sill like the code simplification of this patch. So i updated
the commit message and pushed it. Thanks.
--
Matthias Bolte
http://photron.blogspot.com