Re: [libvirt] [PATCH] Revert "maint: prefer enum over int for virstoragefile structs"
On 05/17/2014 01:05 AM, Roman Bogorodskiy wrote:
Eric Blake wrote:
> This partially reverts commits b279e52f7 and ea18f8b2.
>
> It turns out our code base is full of:
>
> if ((struct.member = virBlahFromString(str)) < 0)
> goto error;
>
This patch fixes the problem for me and the approach looks good,
as other workarounds look quite ugly indeed.
Thanks; pushed. Sorry for leaving the build broken over a weekend.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)