Re: [libvirt PATCH] spec: Use consistent versioning for Obsoletes
On Tue, Sep 27, 2022 at 11:17:00AM +0200, Jiri Denemark wrote:
rpmbuild is complaining it's not recommended to have unversioned
Obsoletes. On the other hand using dynamic version/release is a bit too
much as we know in which release a particular subpackage was removed.
Let's just use the corresponding version in both cases to be consistent
with all other Obsoletes in our spec file.
Yes, Fedora guidelines expect Obsoletes to be fixed wrt the version
in which the package was removed, and not use the dynamic version.
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
libvirt.spec.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 654057bf57..f7d3931b6e 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -574,9 +574,9 @@ Requires: util-linux
Requires: /usr/bin/qemu-img
%endif
%if !%{with_storage_rbd}
-Obsoletes: libvirt-daemon-driver-storage-rbd < %{version}-%{release}
+Obsoletes: libvirt-daemon-driver-storage-rbd < 5.2.0
%endif
-Obsoletes: libvirt-daemon-driver-storage-sheepdog
+Obsoletes: libvirt-daemon-driver-storage-sheepdog < 8.8.0
%description daemon-driver-storage-core
The storage driver plugin for the libvirtd daemon, providing
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|