On Mon, May 02, 2011 at 04:56:53PM -0600, Eric Blake wrote:
* tests/.valgrind.supp: Consolidate bash suppressions. Ignore more libnl issues. ---
Matthias tested on a debian-based system; I found more issues when testing on Fedora 14. With this in place, I had a silent run of 'make -C tests valgrind'.
Shouldn't be a problem applying this before 0.9.1 if it gets acks.
tests/.valgrind.supp | 72 +++++-------------------------------------------- 1 files changed, 8 insertions(+), 64 deletions(-)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 68cfa0c..7190103 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -3,15 +3,7 @@ Memcheck:Leak fun:malloc fun:xmalloc - fun:set_signal - fun:trap_builtin - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:parse_and_execute - obj:/bin/bash - fun:source_file - fun:source_builtin + ... obj:/bin/bash } { @@ -19,61 +11,6 @@ Memcheck:Leak fun:malloc fun:xmalloc - fun:make_command - fun:yyparse - fun:parse_command - fun:read_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak3 - Memcheck:Leak - fun:malloc - fun:xmalloc - obj:/bin/bash - fun:execute_command_internal - obj:/bin/bash - fun:execute_command_internal - fun:execute_command_internal - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:parse_and_execute - fun:command_substitute -} -{ - bashMemoryLeak4 - Memcheck:Leak - fun:malloc - fun:xmalloc - fun:make_bare_simple_command - fun:make_simple_command - fun:yyparse - fun:parse_command - fun:read_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak5 - Memcheck:Leak - fun:malloc - fun:xmalloc - fun:set_signal - fun:trap_builtin - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:execute_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak6 - Memcheck:Leak - fun:malloc - fun:xmalloc fun:make_bare_simple_command fun:make_simple_command fun:yyparse @@ -278,6 +215,13 @@ obj:/usr/lib/libnl.so.1.1 } { + libnlMemoryLeak3 + Memcheck:Leak + fun:?alloc + ... + obj:/lib64/libnl.so.1.1 +} +{ libselinuxMemoryLeak1 Memcheck:Leak fun:malloc
Okay, go for it, ACK, please push Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/