On 09/12/2014 10:36 AM, Yves Vinter wrote:
Authors: Simon Rastello (Bull), Adrien Kantcheff (Bull), Yves Vinter (Bull)
Summary of new added features by modules:
hyperv_driver.c - hypervDomainDefineXML - hypervDomainCreateXML - hypervDomainUndefine - hypervDomainUndefineFlags - hypervDomainShutdown - hypervDomainShutdownFlags - hypervDomainGetVcpus - hypervDomainGetVcpusFlags - hypervConnectGetMaxVcpus - hypervDomainGetMaxVcpus - hypervDomainSetVcpus - hypervDomainSetVcpusFlags - hypervDomainSetMemory - hypervDomainSetMemoryFlags - hypervDomainSetMaxMemory - hypervNodeGetFreeMemory - hypervDomainAttachDevice - hypervDomainAttachDeviceFlags - hypervDomainGetSchedulerParameters - hypervDomainGetSchedulerParametersFlags - hypervDomainGetSchedulerType - hypervConnectGetCapabilities - hypervConnectGetVersion - hypervDomainSetAutostart - hypervDomainGetAutostart
Thanks for the patch. However, it is far too large to easily review. It would be much better if you split this into a series of multiple smaller patches, with each patch focusing on just a few tightly-related interfaces (for example, hypervDomain{DefineXML,CreatexML,Undefine,UndefineFlags} could be one patch, hten hypervDomainShutdown{,Flags} as a second, and so on).
@@ -58,12 +64,97 @@ hypervFreePrivate(hypervPrivate **priv) wsmc_release((*priv)->client); }
+ /* Bull */ + pthread_mutex_destroy(&(*priv)->mutex); +
What are all the "Bull" comments for? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org