On 10/22/2012 09:11 AM, Daniel Veillard wrote:
On Mon, Oct 22, 2012 at 09:07:54AM -0600, Eric Blake wrote:
Thanks; pushed. I'll still wait on the rest of the series until both of the following have happened: positive review, and qemu.git having an actual commit for drive-mirror.
Well 2/11 ought to be pushed, it was looking sane to me but I lacked context for the first chunk to really ACK it !
Indeed - 2/11 is independent; the missing context is that if the user passed the REUSE_EXT flag, but stat() fails with ENOENT, then there is no existing file to reuse and we can't honor the user's request. I'll resubmit that patch independently, anyways, since I got some off-list feedback about the name 'allow_reuse' being a bit confusing compared to the API flag name. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org