Re: [libvirt] [PATCH] v2: Fix uninitialized variable & error reporting in LXC veth setup

On 03/21/2011 09:37 AM, Daniel P. Berrange wrote:

THe veth setup in LXC had a couple of flaws, first brInit did

s/THe/The/

not report any error when it failed. Second vethCreate() did not correctly initialize the variable containing the return code, so could report failure even when it succeeded.

* src/lxc/lxc_driver.c: Report error when brInit fails * src/lxc/veth.c: Fix uninitialized variable --- src/lxc/lxc_driver.c | 8 ++++++-- src/lxc/veth.c | 33 ++++++++++++++++++++++----------- 2 files changed, 28 insertions(+), 13 deletions(-)

ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org