Re: [libvirt] [PATCH hooks 1/1] Add check for Signed-off-by in commit messages
On Mon, Jan 22, 2018 at 08:58:52AM -0500, John Ferlan wrote:
It's also easier than the :
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
line that I keep in a "cheats" file that I always have open so that I
don't have to add it for patches I review. Of course, I could also just
say ACK, but the R-b seems so much more authoritative.
FWIW, in emacs I have some macros that make it quick to type the long
statements, since it is so commonly needed in QEMU
(define-abbrev-table 'global-abbrev-table
'(
("8rev" "Reviewed-by: Daniel P. Berrange
<berrange(a)redhat.com>" nil 1)
("8ack" "Acked-by: Daniel P. Berrange <berrange(a)redhat.com>"
nil 1)
("8test" "Tested-by: Daniel P. Berrange
<berrange(a)redhat.com>" nil 1)
))
With that defined, if I type the word '8rev' and hit enter/spacebar then
it gets auto-expanded - so just as quick as typing 'ACK'.
Now if I
could
only remember or figure out a way to add it to any patches I push
without having to remember to go back and rebase --interactive to add it
(which I rarely ever do).
For sob it is easy you can automate with a non-interactive rebase
$ git rebase -i master -x "git commit --amend --no-edit -s"
For adding R-b/ACK/etc you could set EDITOR=/some/script which appends
them and to the same trick.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|