
20 Mar
2014
20 Mar
'14
6:08 a.m.
On 03/19/2014 06:33 PM, Martin Kletzander wrote:
On Wed, Mar 19, 2014 at 05:17:40PM +0100, Ján Tomko wrote:
Valgrind reported leaking of maxCpus and arch strings from virXPathString, as well as the leak of the machineMaxCpus array.
Use 'tmp' for the strings we don't want to free, to allow freeing of 'str' in the cleanup label and free machineMaxCpus in virCapsReset too. --- src/qemu/qemu_capabilities.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
ACK with the suggestions being optional to squash in.
I've removed the 'tmp' variable and pushed it, thank you for the review. Jan