Re: [libvirt] [PATCH 5/5] util: vircgroupv2: don't error out if enabling controller fails

On Thu, Jun 20, 2019 at 01:25:45PM +0200, Pavel Hrdina wrote: > Currently CPU controller cannot be enabled if there is any real-time > task running and is assigned to non-root cgroup which is the case on > several distributions with graphical environment. > > Instead of erroring out treat it as the controller is not available. > > Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > --- > src/util/vircgroupv2.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c > index 6eeebe2230..9cc64d64d2 100644 > --- a/src/util/vircgroupv2.c > +++ b/src/util/vircgroupv2.c > @@ -425,8 +425,13 @@ virCgroupV2MakeGroup(virCgroupPtr parent ATTRIBUTE_UNUSED, > if (i == VIR_CGROUP_CONTROLLER_CPUACCT) > continue; > > - if (virCgroupV2EnableController(parent, i) < 0) > - return -1; > + if (virCgroupV2EnableController(parent, i) < 0) { > + virResetLastError(); If it's not an error, we should not have logged it in the first place.