Hi,

I didn't review the whole series because I believe you need to look
at merging patches 1 and 2 and seeing how to deal with the new API
of virDomainDeviceDefParse. Since this will change the series a bit
I'll wait for the newer version.

Also, I think your file has different permissions than the one in git. Commit
49520e9e7d fixed the permissions back, but then these patches
gives a warning when applied:

warning: src/test/test_driver.c has type 100644, expected 100755

I recommend changing the permissions of your local file to match
the one from the repo before re-sending this series.



Thanks,


DHB
On 8/1/19 9:54 AM, Ilias Stamatis wrote:
Ilias Stamatis (6):
  test_driver: implement virDomainAttachDeviceFlags
  test_driver: implement virDomainAttachDevice
  test_driver: implement virDomainDetachDeviceFlags
  test_driver: implement virDomainDetachDevice
  test_driver: implement virDomainDetachDeviceAlias
  test_driver: implement virDomainUpdateDeviceFlags

 src/test/test_driver.c | 570 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 570 insertions(+)

--
2.22.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list