Re: [libvirt] [PATCH 04/11] Separate virGetHostname() API contract from driver APIs

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; Currently the virGetHostname() API has a bogus virConnectPtr parameter. This is because virtualization drivers directly reference this API in their virDriverPtr tables, tieing its API design to the public virConnectGetHostname API design. This also causes problems for access control checks since these must only be done for invocations from the public API, not internal invocation. Remove the bogus virConnectPtr parameter, and make each hypervisor driver provide a dedicated function for the driver API impl. This will allow access control checks to be easily inserted later. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- daemon/libvirtd-config.c | 2 +- src/check-driverimpls.pl | 1 - src/libxl/libxl_driver.c | 9 ++++++++- src/lxc/lxc_driver.c | 9 ++++++++- src/openvz/openvz_driver.c | 9 ++++++++- src/parallels/parallels_driver.c | 9 ++++++++- src/qemu/qemu_driver.c | 9 ++++++++- src/qemu/qemu_migration.c | 4 ++-- src/test/test_driver.c | 8 +++++++- src/uml/uml_driver.c | 9 ++++++++- src/util/virutil.c | 2 +- src/util/virutil.h | 2 +- src/vbox/vbox_tmpl.c | 9 ++++++++- src/xen/xen_driver.c | 9 ++++++++- src/xen/xend_internal.c | 4 ++-- 15 files changed, 78 insertions(+), 17 deletions(-)