Re: [libvirt PATCH 1/2] network: Drop UUID handling for default network

On 11/15/20 3:43 PM, Andrea Bolognani wrote: But that automatically generated uuid will not be stored in the original xml in /etc/libvirt, so a new and different uuid will be generated every time libvirt is restarted. I don't know if the solution to this is to modify libvirt so that it rewrites the XML for a network if it has to auto-generate any attributes[*], or to put a canned/static uuid value in the installed xml, or just to declare that we don't care if the uuid changes from one run of libvirtd to the next. But definitely these patches change behavior, so we probably need to point that out and maybe discuss it. BTW, the whole thing of generating a different default.xml for each install of libvirt is a thorn in the side anyway - I looked for the BZ describing the problem and came up with this: https://bugzilla.redhat.com/show_bug.cgi?id=1657041 which isn't the entire discussion, but is part of it. Basically while talking about this in *some venue* (maybe it was IRC, maybe a different BZ?) we decided that we shouldn't be (can't be?) generating files during the package %post_install. Our main topic of discussion was the subnet of the network, but adding/modifying the uuid is just another example of the same undesired behavior. So *that* would be an argument in favor of at least the "don't generate a different uuid at install time" part of your patches. But it doesn't (afaics) lead to a definite resolution of "what should be done instead?". (btw, I'm working / supposed to be working on eliminating the need to modify the subnet address in this same file with a new "autoaddress" function that will replace a fixed IP in a network definition with an indicator that means "find an unused subnet and use that". Doesn't solve the uuid bit though) [*] I have a vague memory that there is (or was?) at least one case where we would automatically update the persistent definition of a domain or network on disk when libvirt started (it was needed due to a change in some attribute or something), but I don't recall the details, don't feel like looking for it right now, and it anyway is not the norm.