On Fri, Jan 30, 2015 at 02:20:57PM +0100, Peter Krempa wrote:
!! this series applies on top of the cleanup series posted earlier !!
Hi, this is my try to implement memory hotplug in libvirt (for the qemu) driver. This series is almost code-complete but is lacking tests and docs as I wanted to agree on design first before attempting to write the documentation.
Additionally this series is also lacking code that would fix memballoon handling but I'm waiting on a clousure how it's supposed to work from qemu's side as it appears to be broken there too.
The basic XML used to add a memory device: <memory model='acpi-dimm'> <target> <size unit='KiB'>524287</size> <node>0</node> </target> </memory>
The <target> subelement is mandatory, whereas the <source> subelement (that contains source numa nodes, source page size ) is optional and is inferred from the NUMA tuning for given target numa node.
Please note that at least one guest numa node has to be configured for the guest for this to work (limitation of qemu).
What's missing in this series: - tests - docs - commit message touch-up - code to audit the memory size changes - code to make memory balloning working with correct size
Looks good to me, but you might want another opinion on the XML format. Jan