Re: [libvirt] [libvirt-gconfig PATCHv2 14/14] Implement gvir_config_domain_setup_default_usb_controllers
On Wed, Apr 11, 2012 at 06:51:48PM +0200, Marc-André Lureau wrote:
On Wed, Apr 11, 2012 at 6:19 PM, Daniel P. Berrange
<berrange(a)redhat.com> wrote:
> The concept of 'default usb controllers' seems very policy based
> to me & different hypervisors will have different views of this.
This is a helper, it is not imposing any policy, but giving you sane
default setup for ICH9 USB2 controllers if you want to.
Deciding on what the default setup is is some kind of policy ) But yeah
it's not imposed since there are still the lower level function.
That said, this function doing something magical is quite odd compared to
the rest of libvirt-gconfig API which directly manipulate xml nodes. A
"simpler" API will probably needed at some point, but maybe it belongs just
above libvirt-gconfig instead of inside it.
Christophe
Attachments:
- attachment.sig (application/pgp-signature — 198 bytes)