Re: [libvirt] [PATCH] storage: Cleanup logical volume creation code

On 03/06/2013 08:04 AM, Jiri Denemark wrote: > @@ -741,11 +741,12 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn, > virCommandAddArg(cmd, pool->def->source.name); > > if (virCommandRun(cmd, NULL) < 0) > - goto cleanup; > + goto error; > > - if ((fdret = virStorageBackendVolOpen(vol->target.path)) < 0) > - goto cleanup; > - fd = fdret; > + virCommandFree(cmd); You'll need a 'cmd = NULL' here so that we don't end up in error: making the same call (virCommandFree() does call VIR_FREE(cmd), but that only sets cmd = NULL in that context, when we return here it's not NULL anymore).